HDDS-14714. Support keeping a configurable number of extra copies of quasi-closed containers.#9829
Open
aswinshakil wants to merge 2 commits intoapache:masterfrom
Open
HDDS-14714. Support keeping a configurable number of extra copies of quasi-closed containers.#9829aswinshakil wants to merge 2 commits intoapache:masterfrom
aswinshakil wants to merge 2 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
For diverged quasi-closed stuck containers, HDDS-12483 keeps two copies of each origin. This change makes the replica counts configurable, so the origin with the highest BCSID can receive more copies than the others for better fault tolerance.The best origin is defined as the one with the highest BCSID among healthy replicas. If the highest BCSID replica is unhealthy, we fall back to the next highest healthy one. If multiple origins tie for the highest healthy BCSID, all of them are treated as best. Two new reconfigurable config keys are introduced:
hdds.scm.replication.quasi.closed.stuck.best.origin.copies (default: 3)
hdds.scm.replication.quasi.closed.stuck.other.origin.copies (default: 2)
With the defaults, the best origin gets 3 copies and all other origins get 2.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14714
How was this patch tested?
Added and updated tests.