refactor: Remove dead code and tidy storage-client internals#983
Open
vdusek wants to merge 7 commits into
Open
refactor: Remove dead code and tidy storage-client internals#983vdusek wants to merge 7 commits into
vdusek wants to merge 7 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #983 +/- ##
==========================================
+ Coverage 89.90% 89.92% +0.01%
==========================================
Files 49 49
Lines 3091 3066 -25
==========================================
- Hits 2779 2757 -22
+ Misses 312 309 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Reverts the api_client injection into AliasResolver/open_by_alias added earlier on this branch so this PR stays a focused dead-code cleanup; the client-lifecycle change is submitted as a separate PR per review feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal cleanup portion of the v4 major-release cleanup. No public API changes.
Dead code
EXIT_CODE_SUCCESS,is_url(),maybe_extract_enum_member_value(), a no-opexcept Exception: raisein_crypto, the unusedhpack/httpcoreScrapy loggers (leftovers from the oldhttpxstack — HTTP now goes throughimpit), the unused_was_final_persist_state_emittedflag, and a discardeddefault_kvs_client.get()call.Tidy-ups
push_datais given an empty list.hash_api_base_url_and_token→hash_api_public_base_url_and_tokento match what it hashes.Packaging
Typing :: Typedclassifier and remove the staleapify-sharedentry from[tool.uv.exclude-newer-package].