Skip to content

Honor configured client metric sampling during simulation speed-up#13792

Open
tclinkenbeard-oai wants to merge 3 commits into
apple:mainfrom
tclinkenbeard-oai:dev/tclinkenbeard/client-metric-configured-sampling-speedup
Open

Honor configured client metric sampling during simulation speed-up#13792
tclinkenbeard-oai wants to merge 3 commits into
apple:mainfrom
tclinkenbeard-oai:dev/tclinkenbeard/client-metric-configured-sampling-speedup

Conversation

@tclinkenbeard-oai

Copy link
Copy Markdown
Collaborator

Problem

When a simulation explicitly configures client metric sampling, a separate simulation speed-up can suppress that sampling. Restart coverage then fails to observe the configured metric workload even though the configured rate is finite.

Change

Keep the speed-up suppression for default sampling, while honoring an explicitly configured finite sampling rate.

Validation

  • fdbclient_test: 90 passed, 0 failed
  • ClientMetricRestart-{1,2}.toml paired restart replay with fault injection and buggify enabled: passed

@foundationdb-ci

This comment has been minimized.

@tclinkenbeard-oai
tclinkenbeard-oai marked this pull request as ready for review July 25, 2026 19:51
@foundationdb-ci

This comment has been minimized.

@foundationdb-ci

This comment has been minimized.

@foundationdb-ci

This comment has been minimized.

@foundationdb-ci

This comment has been minimized.

@foundationdb-ci

This comment has been minimized.

@foundationdb-ci

This comment has been minimized.

@foundationdb-ci

This comment has been minimized.

@foundationdb-ci

This comment has been minimized.

@foundationdb-ci

This comment has been minimized.

@foundationdb-ci

This comment has been minimized.

@foundationdb-ci

This comment has been minimized.

@foundationdb-ci

This comment has been minimized.

@foundationdb-ci

This comment has been minimized.

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-ide on Linux RHEL 9

  • Commit ID: c670d11
  • Duration 0:21:57
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos-m1 on macOS 14.x

  • Commit ID: c670d11
  • Duration 0:34:14
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang-arm on Linux RHEL 9

  • Commit ID: c670d11
  • Duration 0:46:01
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-macos on macOS 14.x

  • Commit ID: c670d11
  • Duration 0:49:10
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-clang on Linux RHEL 9

  • Commit ID: c670d11
  • Duration 0:53:26
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr on Linux RHEL 9

  • Commit ID: c670d11
  • Duration 0:56:19
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)

@foundationdb-ci

Copy link
Copy Markdown
Contributor

Result of foundationdb-pr-cluster-tests on Linux RHEL 9

  • Commit ID: c670d11
  • Duration 1:23:15
  • Result: ✅ SUCCEEDED
  • Error: N/A
  • Build Log terminal output (available for 30 days)
  • Build Workspace zip file of the working directory (available for 30 days)
  • Cluster Test Logs zip file of the test logs (available for 30 days)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants