YulUtilFunctions: reject _bytes == 0 in maskLowerOrderBytesFunction#16754
Open
msooseth wants to merge 1 commit into
Open
YulUtilFunctions: reject _bytes == 0 in maskLowerOrderBytesFunction#16754msooseth wants to merge 1 commit into
msooseth wants to merge 1 commit into
Conversation
The existing assert allowed _bytes == 0, in which case the mask expression (~u256(0)) >> (256 - 8 * _bytes) becomes (~0) >> 256 — implementation-defined in C++ and only happens to yield 0 in boost::multiprecision. The generated Yul would then become `result := and(data, 0x00)`, a zeroizer, which makes no semantic sense for a "mask lower order bytes" helper. No caller passes 0 today; tighten the precondition so future callers can't accidentally trigger the degenerate case. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
This pull request is stale because it has been open for 14 days with no activity. |
github-actions
Bot
added
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maskLowerOrderBytesFunction(_bytes)asserts_bytes <= 32but allows_bytes == 0._bytes == 0, the mask expression(~u256(0)) >> (256 - 8 * _bytes)becomes~0 >> 256— implementation-defined in C++ and only happens to evaluate to0in boost'smultiprecision::number<unchecked<…>>. The emitted Yul becomesresult := and(data, 0x00), a zeroizer.0(verified via grep), so this is not a current bug. Tighten the precondition to_bytes > 0 && _bytes <= 32so future callers can't accidentally hit the degenerate case.maskLowerOrderBytesFunctionDynamicis unaffected — its Yulnot(shl(mul(8, bytes), not(0)))formulation handlesbytes == 0correctly.Test plan