Skip to content

Fix private alias precompilation#1632

Open
cyphercodes wants to merge 1 commit into
arktypeio:mainfrom
cyphercodes:fix-1362-private-alias-jit
Open

Fix private alias precompilation#1632
cyphercodes wants to merge 1 commit into
arktypeio:mainfrom
cyphercodes:fix-1362-private-alias-jit

Conversation

@cyphercodes

Copy link
Copy Markdown

Fixes #1362.

Summary

  • Rebind precompiled traversal functions for nodes owned by a scope when the scope is exported, so aliases that were compiled during cyclic scope resolution do not keep stale references to unresolved context ids.
  • Add a regression test for a cyclic discriminated union that references a private alias.

Tests

  • pnpm exec mocha --no-config --no-package --node-option conditions=ark-ts --node-option import=tsx --require ./ark/repo/mocha.globalSetup.ts ark/type/__tests__/realWorld.test.ts --skipTypes
  • pnpm exec mocha --no-config --no-package --node-option conditions=ark-ts --node-option import=tsx --require ./ark/repo/mocha.globalSetup.ts ark/type/__tests__/scope.test.ts ark/type/__tests__/discrimination.test.ts --skipTypes
  • NODE_OPTIONS=--max-old-space-size=4096 pnpm typecheckRepo
  • pnpm exec prettier --check ark/schema/scope.ts ark/type/__tests__/realWorld.test.ts

@pullfrog

pullfrog Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Run failed. View the logs →

Pullfrog  | Rerun failed job ➔View workflow run | via Pullfrog | Using Kimi K2 (free via Pullfrog for OSS) | 𝕏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To do

Development

Successfully merging this pull request may close these issues.

is not a funtion when using private alias

1 participant