fix: arrow.get() behaviour for tzinfo=None#1283
Open
YousafZahid1 wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1283 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 2315 2319 +4
Branches 358 359 +1
=========================================
+ Hits 2315 2319 +4 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1259
What this PR fixes
Issue: arrow.get() behaviour for tzinfo=None
Issue description:
Issue Description
When
arrow.get()is invoked with a value, a format and atzinfokeyword argument that isNone, the behavior is different than if the keyword argument were omitted, which is slightly confusing (at least to me).Example:
where account.timezone is optional and can be None.
This will crash because it will attempt to invoke the 3+ argument constructor of
Arrow:The reason is that in the factory, the check assumes that a single keyword argument and a
Nonetzinfo means we've not passed a tzinfo, when in fact we've passedNone.