Stop testing unsupported Python 3.8 and 3.9 (again)#417
Open
DimitriPapadopoulos wants to merge 1 commit intoastanin:masterfrom
Open
Stop testing unsupported Python 3.8 and 3.9 (again)#417DimitriPapadopoulos wants to merge 1 commit intoastanin:masterfrom
DimitriPapadopoulos wants to merge 1 commit intoastanin:masterfrom
Conversation
Either support Python 3.8 and 3.9 officially and keep testing these versions, or stop testing. This grey area where you don't support versions but still test them just in case doesn't help. For example, ruff targets `requires-python` and generates code that may not be compatible with earlier versions. Such code will break CI tests with unsupported versions of Python.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #417 +/- ##
=======================================
Coverage 84.45% 84.45%
=======================================
Files 1 1
Lines 907 907
Branches 218 218
=======================================
Hits 766 766
Misses 107 107
Partials 34 34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Either support Python 3.8 and 3.9 officially and keep testing these versions, or stop testing. This grey area where you don't support versions but still test them just in case doesn't help. For example, ruff targets
requires-pythonand generates code that may not be compatible with earlier versions. Such code will break CI tests with unsupported versions of Python.