add mage:lint targets#431
Open
ivanauth wants to merge 1 commit into
Open
Conversation
Resolves authzed#429. Adds a `Lint` mage namespace mirroring the linters CI runs so devs can run `mage lint` locally and catch issues before pushing. Targets: - `lint:all` — runs `lint:go` + `lint:extra` - `lint:go` — runs `gen:all` (codegen drift check), then gofumpt, golangci-lint --fix, and `go mod tidy` serially - `lint:extra` — yaml, markdown, kustomize build - Sub-targets are also individually runnable (e.g. `mage lint:gofumpt`) Notes: - `lint:all` and `lint:go` use `mg.SerialDeps`: `lint:go` writes to config/crds + config/rbac via codegen, and `lint:kustomize` reads ./config, so they must not race; the gofumpt/golangci-lint/tidy chain inside `lint:go` also mutates files in place. - `lint:tidy` runs in root + ./tools + ./e2e. ./magefiles is omitted because it has no separate go.mod and resolves to the root module. - golangci-lint is pinned to v2.12.2 to match the version used by `authzed/actions/golangci-lint`. - Targets that use `--fix` (gofumpt, golangci-lint) modify files in place, matching the pattern in sibling `authzed/spicedb` repo. - Generalized `checkDocker` error message; it is now used by `lint:yaml` and `lint:markdown` in addition to e2e tests. Also fixes a pre-existing MD059 violation in CODE-OF-CONDUCT.md that the new `lint:markdown` target surfaces.
ivanauth
force-pushed
the
ic/mage-lint-targets
branch
from
c58b0c8 to
f945acd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #429.
Adds a
Lintmage namespace mirroring the linters CI runs, so developers can runmage lintlocally and catch issues before pushing.