Try to fix projectile-go-project-p under sub-folder of the one has project marker

[ccqpein]

Try to fix the issue #1744

---

Before submitting a PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

• The commits are consistent with our contribution guidelines
• You've added tests (if possible) to cover your change(s)
• All tests are passing (eldev test)
• The new code is not generating bytecode or M-x checkdoc warnings
• You've updated the changelog (if adding/changing user-visible functionality)
• You've updated the docs (when adding new project types, configuration options, commands, etc)

Thanks!

[github-actions]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed soon if no further activity occurs. Thank you for your contribution and understanding!

[github-actions]

This issue been automatically closed due to lack of activity. Feel free to re-open it if you ever come back to it.

[bbatsov]

Thanks for taking a crack at this. I don't think we can flip the default order of projectile-project-root-functions here, though - it isn't specific to Go. Moving projectile-root-top-down ahead of projectile-root-bottom-up changes the root-detection precedence for every project: instead of the nearest (innermost) marker winning, the outermost one would. That quietly changes which directory is treated as the project root in nested repos, submodules and monorepos for everyone, which is a much bigger and riskier change than the Go case that prompted it.

For the original issue I'd rather not touch the global default - better handled with a Go-specific root function/marker, or by the affected user reordering projectile-project-root-functions in their own config (it's a defcustom for exactly this reason).

I'll leave this open as a design discussion rather than merge as-is.