[Fix #1909] Pass the project root to predicate marker-files functions#2023
Merged
Conversation
When `marker-files' is a predicate, `projectile-detect-project-type' called it with DIR, which is nil when detecting the current project's type - so the predicate could never match the current project. Resolve the root up front and pass it to the predicate (and reuse it for the type cache key). Also document the predicate contract in `projectile-register-project-type'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a project type's
marker-filesis a predicate function,projectile-detect-project-typecalled it withdir, which is nil when detecting the current project's type. So a predicate marker could never match the current project (it always got nil). Now the root is resolved up front and passed to the predicate (and reused for the type-cache key). The predicate contract is also documented inprojectile-register-project-type.Fixes #1909.