[Fix #1872] Clarify that marker-files lists are AND-ed#2027
Merged
Conversation
Listing several marker-files requires ALL of them to be present for the type to match, which surprised a user who expected any-of semantics. Spell this out in the `projectile-register-project-type' docstring and the manual, and point to predicate markers for matching when any one of several files is present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A user registered a type with two marker files expecting it to match when either was present, but a marker-files list requires all of them (logical AND). This documents that semantics in the
projectile-register-project-typedocstring and the manual, and points to predicate markers for any-of matching.Fixes #1872.