ElasticNetCVLearner: Fix parameter alphas#7294
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7294 +/- ##
=======================================
Coverage 89.03% 89.03%
=======================================
Files 336 336
Lines 74433 74427 -6
=======================================
- Hits 66273 66268 -5
+ Misses 8160 8159 -1 🚀 New features to boost your workflow:
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
ElasticNetCVLearnerrequiresintor an array, and no longer acceptsNone.Description of changes
Set it to the default value,
100. This duplicates the value ofn_alpha, which we need to keep for compatibilityWe have a problem with scikit versions and should probably require 1.7. We currently require 1.5
intargument foralpha; it requires a list orNone(default, effectively sets it to 100).intand deprecatesNone; it defaults to100.None.There is no common argument type for 1.5 and 1.9. If we omit the argument to use the default, we have a problem with signature.
The easiest solution is to require Scikit 1.7
Includes