fix: Mark the reversed() cache as valid after rebuilding it#61
Merged
Conversation
Benchmark ResultsPackage ordered_set:
Benchmarks provided with 💙 by Dart Benchmark Action. |
Coverage Report for CI Build 29873276610Coverage increased (+0.03%) to 97.537%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
luanpotter
approved these changes
Jul 21, 2026
luanpotter
left a comment
Member
There was a problem hiding this comment.
LGTM, shocked it was never set!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
_validReverseCachestarts outtrueand is set tofalseon every mutation (add,remove,clear), but it was never set back totruewhenreversed()rebuilt the cache. As a result, after the first mutation every singlereversed()call did a fulltoList(growable: false)of the set, and the "cache" never served a single hit.This is a significant hidden cost for Flame, where
Component.componentsAtLocationcallschildren.reversed()for every component with children on every pointer event, so every game pays an O(n) list materialization per node per hit test.The fix marks the cache valid after rebuilding it. Invalidation behavior is unchanged: any mutation still resets the flag, and the existing
reversed properly invalidates cachetests still pass. Added a regression test to both implementations asserting that the returned iterable is identical between calls when no mutation happened, and is correctly rebuilt after a mutation.Found while working on flame-engine/flame#3957.