You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
❌ Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.33%. Comparing base (6ddc2b4) to head (6d3ba01). ⚠️ Report is 985 commits behind head on main.
The Miri check is failing with a runner infrastructure issue (Permission denied (os error 13) in boa_macros). I haven't modified any macros or dependencies, and pushing a fresh commit didn't clear the cache. Could a maintainer please clear the Actions cache or re-run the job?
Looks like a non-empty commit was enough to clear the staled cache and everything should be fine now. Let me know, if you need any changes from my side. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C-BuiltinsPRs and Issues related to builtins/intrinsicsC-IntlChanges related to the `Intl` implementationWaiting On ReviewWaiting on reviews from the maintainers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactoring of the logic added by 26271b7. This PR is a prerequisite for #5199
It changes the following:
toLocaleString,toLocaleDateString, andtoLocaleTimeStringformat_date_time_localeas unnecessaryTesting:
cargo test -p boa_engine --lib -- date::tests::date_proto_to_locale_string_intl(skipped)cargo test -p boa_engine --features intl_bundled --lib -- date::tests::date_proto_to_locale_string_intl(passed)