Skip to content

Bump dependencies#3730

Merged
bobvandevijver merged 8 commits into
6.1from
dependencies
May 29, 2026
Merged

Bump dependencies#3730
bobvandevijver merged 8 commits into
6.1from
dependencies

Conversation

dependabot Bot and others added 4 commits May 29, 2026 20:55
Bumps [js-cookie](https://github.com/js-cookie/js-cookie) from 3.0.5 to 3.0.7.
- [Release notes](https://github.com/js-cookie/js-cookie/releases)
- [Commits](js-cookie/js-cookie@v3.0.5...v3.0.7)

---
updated-dependencies:
- dependency-name: js-cookie
  dependency-version: 3.0.7
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [tmp](https://github.com/raszi/node-tmp) from 0.2.5 to 0.2.7.
- [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md)
- [Commits](raszi/node-tmp@v0.2.5...v0.2.7)

---
updated-dependencies:
- dependency-name: tmp
  dependency-version: 0.2.7
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
On PHP 8.4, mb_trim()/mb_rtrim() are analysed as string|false (the
mbstring polyfill's implementation has no return type, and the native
8.4 stubs are nullable-on-failure). Combined with json_encode()'s
existing string|false return, this surfaced level-8 errors in files
unrelated to any one feature.

Add explicit (string) casts at the call sites in Canonical, the
translation trait, the frontend menu builder, the content repository
search, and the excerpt helper. These are no-ops on PHP 8.2/8.3 and
satisfy the analyser on 8.4. Drop the now-obsolete ContentRepository
mb_trim baseline entry, which the json_encode cast resolves.
Copilot AI review requested due to automatic review settings May 29, 2026 19:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps selected JavaScript dependencies and applies PHPStan-oriented casts around mb_trim() / mb_rtrim() usage so the code remains compatible with PHP 8.4 static analysis while preserving existing behavior.

Changes:

  • Updated axios to ^1.16.1 and refreshed lockfile entries for axios, js-cookie, and tmp.
  • Added explicit (string) casts around mb_trim() / mb_rtrim() results in strict string contexts.
  • Removed the now-obsolete PHPStan baseline ignore for ContentRepository.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/Twig/ContentExtension.php Casts mb_rtrim() result before returning a string excerpt.
src/Repository/ContentRepository.php Casts json_encode() and mb_trim() results before building the search term.
src/Menu/FrontendMenuBuilder.php Casts trimmed menu links before URI checks.
src/Entity/Translatable/BoltTranslationTrait.php Casts trimmed string values before measuring length.
src/Canonical.php Casts trimmed scheme before assigning to a string property.
phpstan-baseline.php Removes the resolved PHPStan ignore entry.
package.json Bumps axios dependency constraint.
package-lock.json Updates resolved package versions and dependency metadata.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bobvandevijver bobvandevijver force-pushed the dependencies branch 3 times, most recently from 53a0b62 to 3cfab98 Compare May 29, 2026 20:41
@bobvandevijver bobvandevijver merged commit f347a1d into 6.1 May 29, 2026
34 of 37 checks passed
@bobvandevijver bobvandevijver deleted the dependencies branch May 29, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants