Bump dependencies#3730
Merged
Merged
Conversation
bobvandevijver
commented
May 29, 2026
Member
- Bump js-cookie from 3.0.5 to 3.0.8 #3725
- Bump tmp from 0.2.5 to 0.2.7 #3728
- Bump axios from 1.15.2 to 1.16.0 #3729
- Make default query limit configurable via query_default_limit #3727 (single commit)
Bumps [js-cookie](https://github.com/js-cookie/js-cookie) from 3.0.5 to 3.0.7. - [Release notes](https://github.com/js-cookie/js-cookie/releases) - [Commits](js-cookie/js-cookie@v3.0.5...v3.0.7) --- updated-dependencies: - dependency-name: js-cookie dependency-version: 3.0.7 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [tmp](https://github.com/raszi/node-tmp) from 0.2.5 to 0.2.7. - [Changelog](https://github.com/raszi/node-tmp/blob/master/CHANGELOG.md) - [Commits](raszi/node-tmp@v0.2.5...v0.2.7) --- updated-dependencies: - dependency-name: tmp dependency-version: 0.2.7 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
On PHP 8.4, mb_trim()/mb_rtrim() are analysed as string|false (the mbstring polyfill's implementation has no return type, and the native 8.4 stubs are nullable-on-failure). Combined with json_encode()'s existing string|false return, this surfaced level-8 errors in files unrelated to any one feature. Add explicit (string) casts at the call sites in Canonical, the translation trait, the frontend menu builder, the content repository search, and the excerpt helper. These are no-ops on PHP 8.2/8.3 and satisfy the analyser on 8.4. Drop the now-obsolete ContentRepository mb_trim baseline entry, which the json_encode cast resolves.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps selected JavaScript dependencies and applies PHPStan-oriented casts around mb_trim() / mb_rtrim() usage so the code remains compatible with PHP 8.4 static analysis while preserving existing behavior.
Changes:
- Updated
axiosto^1.16.1and refreshed lockfile entries foraxios,js-cookie, andtmp. - Added explicit
(string)casts aroundmb_trim()/mb_rtrim()results in strict string contexts. - Removed the now-obsolete PHPStan baseline ignore for
ContentRepository.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/Twig/ContentExtension.php |
Casts mb_rtrim() result before returning a string excerpt. |
src/Repository/ContentRepository.php |
Casts json_encode() and mb_trim() results before building the search term. |
src/Menu/FrontendMenuBuilder.php |
Casts trimmed menu links before URI checks. |
src/Entity/Translatable/BoltTranslationTrait.php |
Casts trimmed string values before measuring length. |
src/Canonical.php |
Casts trimmed scheme before assigning to a string property. |
phpstan-baseline.php |
Removes the resolved PHPStan ignore entry. |
package.json |
Bumps axios dependency constraint. |
package-lock.json |
Updates resolved package versions and dependency metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
7030f98 to
b48d5cf
Compare
53a0b62 to
3cfab98
Compare
3cfab98 to
e0eb8f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.