ref: Convert IITM and RITM to typescript#2206
Conversation
Abhijeet Prasad (AbhiPrasad)
left a comment
There was a problem hiding this comment.
This makes it way harder to maintain this w/ upstream. Do we really need to convert rn?
Abhijeet Prasad (@AbhiPrasad) Hm.. It's a very valid point. And I am not sure what is best. Feel free to block me or think this through with me. My thought process was that we will most likely end up modifying the packages in some way or another (like removing functionality around configuration that we don't need, maybe a slight adjustment here and there), and the type checking would give us actually a huge safety net in that case. I also thought that nowadays, syncing with upstream is likely not as huge of a pain as it has been before (?). It's all just my best guess on how things play out. |
|
there's a bunch of iitm improvements coming in the pipeline (see nodejs/import-in-the-middle#265 as an example), so I'd atleast hold off for a bit before doing the ts conversion. |
I also just saw those because your comment made me check haha. That particular PR changes 7 LOC of actual package code. Lemme actually try and sync based off this PR and see how tough it is. |
|
Development there picked up after like 6 months of almost inactivity. Great timing haha |
No description provided.