Skip to content

ref: Convert IITM and RITM to typescript#2206

Open
Luca Forstner (lforst) wants to merge 3 commits into
mainfrom
lforst/modernize-ir-itm
Open

ref: Convert IITM and RITM to typescript#2206
Luca Forstner (lforst) wants to merge 3 commits into
mainfrom
lforst/modernize-ir-itm

Conversation

@lforst

@lforst Luca Forstner (lforst) commented Jul 7, 2026

Copy link
Copy Markdown
Member

No description provided.

@lforst Luca Forstner (lforst) changed the base branch from main to lforst/orchestrion-esquery-types July 7, 2026 15:45
@lforst Luca Forstner (lforst) changed the title lforst/modernize ir itm ref: Convert IITM and RITM to typescript Jul 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes it way harder to maintain this w/ upstream. Do we really need to convert rn?

@lforst

Luca Forstner (lforst) commented Jul 7, 2026

Copy link
Copy Markdown
Member Author

This makes it way harder to maintain this w/ upstream. Do we really need to convert rn?

Abhijeet Prasad (@AbhiPrasad) Hm.. It's a very valid point. And I am not sure what is best. Feel free to block me or think this through with me.

My thought process was that we will most likely end up modifying the packages in some way or another (like removing functionality around configuration that we don't need, maybe a slight adjustment here and there), and the type checking would give us actually a huge safety net in that case. I also thought that nowadays, syncing with upstream is likely not as huge of a pain as it has been before (?). It's all just my best guess on how things play out.

Base automatically changed from lforst/orchestrion-esquery-types to main July 7, 2026 16:05
@AbhiPrasad

Copy link
Copy Markdown
Member

there's a bunch of iitm improvements coming in the pipeline (see nodejs/import-in-the-middle#265 as an example), so I'd atleast hold off for a bit before doing the ts conversion.

@lforst

Copy link
Copy Markdown
Member Author

there's a bunch of iitm improvements coming in the pipeline (see nodejs/import-in-the-middle#265 as an example), so I'd atleast hold off for a bit before doing the ts conversion.

I also just saw those because your comment made me check haha. That particular PR changes 7 LOC of actual package code. Lemme actually try and sync based off this PR and see how tough it is.

@lforst

Copy link
Copy Markdown
Member Author

Development there picked up after like 6 months of almost inactivity. Great timing haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants