Skip to content

Route container host-gateway to loopback on Windows #6859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Badbird5907 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

Route container host-gateway to loopback on Windows #6859

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/workerd/server/container-client.c++
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -874,9 +874,10 @@ kj::Promise<void> warnAboutStaleSnapshotVolumes(kj::Network& network, kj::String
}

// Returns the gateway IP on Linux for direct container access.
// Returns kj::none on macOS where Docker Desktop routes host-gateway to host loopback.
// Returns kj::none on macOS and Windows where Docker Desktop routes host-gateway to host loopback
// through the VM (so the bridge gateway IP is not a local interface on the host).
kj::Maybe<kj::String> gatewayForPlatform(kj::String gateway) {
#ifdef __APPLE__
#if defined(__APPLE__) || defined(_WIN32)
return kj::none;
#else
return kj::mv(gateway);
Expand Down
Loading