Images binding: allow setting headers on .response()#6869
Open
Monark-Arkmon wants to merge 2 commits into
Open
Images binding: allow setting headers on .response()#6869Monark-Arkmon wants to merge 2 commits into
Monark-Arkmon wants to merge 2 commits into
Conversation
832525e to
0eb7d7c
Compare
mglewis
approved these changes
Jul 8, 2026
Contributor
|
LGTM ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
response() now accepts an optional headers option, so you can set Cache-Control (or anything else) without manually rebuilding the Response:
content-type is always taken from the transformed image and can't be overridden by a header you pass in.
This pairs nicely with Workers Cache - now that Cache-Control on the response is all you need to get a transform cached at the edge, it was a bit annoying to have to hand-roll headers just to set that one thing.