Skip to content

feat(ui): update SignInForm default authentication error message #1811

Merged
franzheidl merged 5 commits into
mainfrom
franz-update-SignInForm-1808
Jul 15, 2026
Merged

feat(ui): update SignInForm default authentication error message #1811
franzheidl merged 5 commits into
mainfrom
franz-update-SignInForm-1808

Conversation

@franzheidl

@franzheidl franzheidl commented Jul 14, 2026

Copy link
Copy Markdown
Member

This PR updates the default authentication message on the SignInForm to "Unable to authenticate the provided credentials.", and adds a story showing the default error on the form when the error prop is passed as true.

Screenshots

Bildschirmfoto 2026-07-14 um 17 28 28

Testing Instructions

  1. pnpm i
  2. pnpm run test SignInForm

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

Signed-off-by: Franz Heidl <franz.heidl@sap.com>
Signed-off-by: Franz Heidl <franz.heidl@sap.com>
Signed-off-by: Franz Heidl <franz.heidl@sap.com>
@changeset-bot

changeset-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 17b5f82

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@cloudoperators/juno-ui-components Patch
@cloudoperators/juno-app-carbon Patch
@cloudoperators/juno-app-doop Patch
@cloudoperators/juno-app-example Patch
@cloudoperators/juno-app-greenhouse Patch
@cloudoperators/juno-app-heureka Patch
@cloudoperators/juno-app-supernova Patch
@cloudoperators/juno-app-template Patch
@cloudoperators/juno-messages-provider Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Signed-off-by: Franz Heidl <franz.heidl@sap.com>
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-07-15 09:32 UTC

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the SignInForm component in @cloudoperators/juno-ui-components to use a new default authentication error message and documents/demonstrates this behavior via Storybook and tests.

Changes:

  • Updated the default error={true} message to “Unable to authenticate the provided credentials.”
  • Added a Storybook story that renders the form with the default error state.
  • Updated unit tests and added a changeset for the patch release.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
packages/ui-components/src/components/SignInForm/SignInForm.component.tsx Updates the default error message string and its prop documentation.
packages/ui-components/src/components/SignInForm/SignInForm.test.tsx Updates assertions to match the new default error message.
packages/ui-components/src/components/SignInForm/SignInForm.stories.tsx Adds a WithError story to showcase the default error state.
.changeset/shiny-clowns-divide.md Adds a patch changeset for the UI components package.

Comment thread .changeset/shiny-clowns-divide.md
@franzheidl franzheidl marked this pull request as ready for review July 15, 2026 08:24
@franzheidl franzheidl requested a review from a team as a code owner July 15, 2026 08:24
edda
edda previously approved these changes Jul 15, 2026
MartinS-git
MartinS-git previously approved these changes Jul 15, 2026
Signed-off-by: Franz Heidl <franz.heidl@sap.com>
@franzheidl franzheidl dismissed stale reviews from MartinS-git and edda via 17b5f82 July 15, 2026 08:49
@franzheidl franzheidl merged commit b736c03 into main Jul 15, 2026
25 checks passed
@franzheidl franzheidl deleted the franz-update-SignInForm-1808 branch July 15, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants