[FEATURE]: Introduce URI allow-list for HttpTask to mitigate SSRF#1140
Open
RinZ27 wants to merge 2 commits into
Open
[FEATURE]: Introduce URI allow-list for HttpTask to mitigate SSRF#1140RinZ27 wants to merge 2 commits into
RinZ27 wants to merge 2 commits into
Conversation
Author
|
Fixed the unit test failure in The security validation tests were making real network calls to external domains, which caused Verified all tests in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
The current
HttpTaskimplementation allows arbitrary HTTP requests to any URI provided in the workflow definition. This poses a significant security risk in multi-tenant or enterprise environments, as it could be exploited for Server-Side Request Forgery (SSRF) to probe internal networks or access sensitive metadata services (e.g., AWS/GCP metadata endpoints).I've introduced a configurable URI allow-list mechanism using regular expressions. This allows administrators to restrict the set of URIs that
HttpTaskis permitted to interact with.HttpTaskPropertiesto manage theconductor.tasks.http.urlAllowListconfiguration.HttpTaskthat checks the destination URI against the configured allow-list.FAILED_WITH_TERMINAL_ERRORand a clear security violation message.Alternatives considered
Considered implementing a hardcoded block-list for common metadata endpoints, but a configurable allow-list provides better flexibility and security for varying network architectures.