test: use loopback address for HTTP timeout test#1153
Open
codingkiddo wants to merge 1 commit into
Open
Conversation
Signed-off-by: Vinod Kumar <codingkiddo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
This PR updates
HttpTaskTestto use a loopback127/8address instead of10.255.14.15for the HTTP connection timeout test.The previous address can behave differently depending on the local/network environment. In some environments it may fail immediately with
Network unreachable, which means the test does not validate the intended timeout behavior.Using a loopback address keeps the test focused on the intended timeout scenario and avoids depending on external/private-network routing behavior.
Issue #1109
Alternatives considered
I considered keeping the existing RFC1918 address, but that leaves the test dependent on environment-specific network routing behavior.
I also considered using another non-loopback unroutable address, but a
127/8loopback address is more deterministic for this test scenario and matches the direction suggested in the issue.