Add support for building the ggml-virtgpu image#2467
Add support for building the ggml-virtgpu image#2467kpouget wants to merge 2 commits intocontainers:mainfrom
ggml-virtgpu image#2467Conversation
Summary of ChangesHello @kpouget, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive support for building a new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds support for building a remoting image that utilizes ggml-virtgpu. The changes include a new Containerfile for this image and substantial updates to the build scripts to handle the new remoting target. The overall approach is sound. However, I've identified a few areas for improvement in the shell scripts, including a potential bug in how CMake flags are configured, error messages being directed to stdout instead of stderr, and some inconsistencies in shell syntax. My review provides specific suggestions to address these points.
Reviewer's GuideAdds support for building a new File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Signed-off-by: Kevin Pouget <kpouget@redhat.com>
Signed-off-by: Kevin Pouget <kpouget@redhat.com>
This PR adds the ability to build the
remotingimage in Ramalama. This image relies on the recently-introducedggml-virtgpullama.cpp backend for executing GGML operations outside of the virtual machine. This is particularly useful on MacOS, where the Linux VM is mandatory for running containers. Theggml-virtgpu, along with its host-side library theggml-virtgpu-backendallows the container to leverage theggml-metalnative GPU acceleration.See this blog post for the steps to reproduce:
and this repository for the latest builds:
The source code is now merged in llama.cpp:
The Virglrenderer library is MR pending review:
I marked this PR as draft until PR ggml-org/llama.cpp#19846 is merged and I can relaunch the build to validate it against the latest rebase.
Summary by Sourcery
Add a new remoting container image that uses the ggml-virtgpu backend and optional Vulkan-based API remoting support, including required build and runtime dependencies.
New Features:
Enhancements:
Build: