feat(storybook): Open Graph share-preview review & recommendations#6232
Open
tsahimatsliah wants to merge 1 commit into
Open
feat(storybook): Open Graph share-preview review & recommendations#6232tsahimatsliah wants to merge 1 commit into
tsahimatsliah wants to merge 1 commit into
Conversation
Adds an "Open Graph" Storybook section auditing daily.dev's outbound link previews across every share surface (article, shared post, profile/DevCard, squad, squad invite, source, tag, comment, referral, Plus, homepage) and proposing a unified "Layout A" recommended template. - The current column renders the real images daily.dev serves today; the recommended column renders the Layout A cover for the same real entity so the before/after is apples-to-apples. - Single source of truth in cover.tsx (Layout A atoms + OgCover); RecommendedOg in dailyOgImages.tsx is the adapter every page consumes. - Includes guidelines/research, an X (Twitter) deep dive, a Satori template spec, a benchmark of how the best platforms unfurl, and a link copy/metadata page. Docs/review only — Storybook stories plus one preview.tsx sidebar entry; no app/runtime code paths are touched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds a new Open Graph Storybook section that audits daily.dev's outbound link previews across every share surface and proposes a unified, on-brand recommended template ("Layout A"). Engineering-ready version of the design mock-up in #6231.
cover.tsx(Layout A atoms +OgCover);RecommendedOgindailyOgImages.tsxis the adapter every page consumes.What changed vs the mock-up (#6231)
coverDna.tsx, the standaloneCover/Source/Headline/ArtBoxatoms, unused color constants,OgFrame).Docs/review only — no app/runtime code paths are touched (Storybook stories under
packages/storybookplus onepreview.tsxsidebar entry).Events
No new tracking events.
Experiment
No new experiments.
Manual Testing
Storybook-only change.
pnpm --filter storybook buildsucceeds, the strict typecheck guard passes for changed files, and eslint is clean across the section.🤖 Generated with Claude Code
Preview domain
https://claude-brave-poitras-c782c4.preview.app.daily.dev