test: assert streaming table partitioning survives non-full-refresh alter#1528
Open
sd-db wants to merge 2 commits into
Open
test: assert streaming table partitioning survives non-full-refresh alter#1528sd-db wants to merge 2 commits into
sd-db wants to merge 2 commits into
Conversation
…lter A metadata-only change to a streaming table takes the alter path, which issues CREATE OR REFRESH rather than a full replace. Assert the existing partitioning is retained so a regression that dropped the PARTITIONED BY clause would be caught.
Coverage report
This PR does not seem to contain any modification to coverable code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Streaming-table config changes that don't touch
partition_bytake the alter path, which issuesCREATE OR REFRESH STREAMING TABLE ... PARTITIONED BY (...)rather than a full replace. There was no functional assertion that the existing partitioning actually survives that path:check_state_alter_change_is_appliedverifies the refresh schedule, comment, and tblproperties, but never re-readspartition_by.This adds a server-observable assertion to
TestStreamingTableChangesApply::test_change_is_applied_via_alter: after a metadata-only alter, it re-reads the relation config and assertspartition_by == ["id"].Testing
TestStreamingTableChangesApply::test_change_is_applied_via_alter— passedTestStreamingTableChangesApply::test_change_is_applied_via_replace(regression; shares the helper) — passedpre-commit run(ruff / ruff format / mypy) — passed