fix sql validator BIS_CentralBankPolicyRate#2095
Merged
niveditasing merged 4 commits intoJul 21, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the validation configuration by replacing variableMeasured with StatVar in SQL queries and switching the deletion validator from DELETED_RECORDS_COUNT to DELETED_RECORDS_PERCENT with a threshold of 0.1. The reviewer pointed out that the DELETED_RECORDS_PERCENT validator uses a 0-100 scale, meaning a threshold of 0.1 restricts deletions to 0.1% instead of 10%. They suggested adjusting the threshold to 10 if a 10% limit was intended.
Contributor
|
LGTM |
vish-cs
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added golden rules & also modified the SQL_VALIDATOR queries as per new differ format
Testing results of SQL_VALIDATOR queries : https://storage.mtls.cloud.google.com/datcom-import-test/statvar_imports/bis/bis_central_bank_policy_rate/BIS_CentralBankPolicyRate/2026_07_17T03_26_57_208559_07_00/input0/validation/validation_output.csv