Added Golden Checks for EIA Imports [EIA_Electricity, EIA_Coal, EIA_Petroleum, EIA_NaturalGas, EIA_International, EIA_TotalEnergy, EIA_SEDS, EIA_NuclearOutages], NewYork_Education and CensusCountyBusinessPatterns#2101
Open
kartik-s21 wants to merge 25 commits into
Conversation
Code fix unenergy
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds validation configurations and golden observation/summary files for several US EIA open data imports and New York education datasets. While many golden files were successfully added, several referenced golden summary report files are missing from the PR, specifically those for EIA Electricity, EIA Petroleum, EIA Total Energy, and New York English and Math education data. These missing files must be generated and included to ensure the validation checks can run successfully.
kartik-s21
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces golden checks for EIA Imports, NewYork_Education, and CensusCountyBusinessPatterns. By adding these golden test files, we ensure that future data imports and processing scripts produce consistent output, preventing unexpected regressions.
Key Changes
Added Golden Files: Generated and added golden test files for EIA imports, New York Education data, and Census County Business Patterns data (accounting for the majority of the +10,900 line additions).
Test Results (validation_output.csv)-
EIA_Electricity - link SOP
EIA_Coal - link SOP
EIA_Petroleum - link SOP
EIA_NaturalGas- link SOP
EIA_SEDS - link SOP
EIA_NuclearOutages - link SOP
EIA_TotalEnergy - link SOP
EIA_International - link SOP
NOTE - For EIA_International, cron scheduler is corrected as it was previously not working. Also, a CL is raised to resolve the missing_references issue. link
NewYork_Education - link SOP
CensusCountyBusinessPatterns - link SOP