Generate SV names#641
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 72 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
There was a problem hiding this comment.
Code Review
This pull request introduces StatVarNameGenerator, a utility class designed to generate readable names for StatisticalVariable nodes when their name property is missing, and integrates it into McfMutator. The review feedback focuses on performance optimizations and code cleanup within the new utility class. Key recommendations include defining thread-safe, static final constants for Pattern, Splitter, and Joiner instances to avoid overhead, removing redundant namespace stripping and condition checks, and eliminating the unused nodeId parameter from generateName along with updating its callers and tests.
Description: This PR introduces StatVarNameGenerator to automatically construct human-readable display names for StatisticalVariable nodes that are missing a name property during MCF mutation.
Changes:
Added/Updated Tests: