chore: Clean up dead code methods in AggregationOrchestrator#650
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | -8 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the unused 'get_active_stages' and 'execute_stage' methods from the orchestrator, refactoring the corresponding tests to use the 'run' method instead. Feedback suggests enhancing the 'test_run_entity_aggregation' test to verify that the entity generator is called with the correct configuration and that the aggregation deleter is properly invoked.
SandeepTuniki
marked this pull request as ready for review
July 16, 2026 13:10
shixiao-coder
approved these changes
Jul 16, 2026
SandeepTuniki
enabled auto-merge (squash)
July 16, 2026 13:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that Jetski created some dead code in
orchestrator.pythat is only called in unit tests and not in production code. I missed this previously.This PR cleans them up and rewrites the unit tests to avoid relying on such unused code.