fix(mobile): address safe area insets for page and drawer components#6469
Open
nmerget wants to merge 12 commits into
Open
fix(mobile): address safe area insets for page and drawer components#6469nmerget wants to merge 12 commits into
nmerget wants to merge 12 commits into
Conversation
github-project-automation
Bot
moved this to 🏗 In progress
in UX Engineering Team Backlog
🦋 Changeset detectedLatest commit: 37e7cb0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nmerget
moved this from 🏗 In progress
to 🎁 Ready for review
in UX Engineering Team Backlog
github-actions
Bot
added
📕documentation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to improve mobile rendering by accounting for device safe-area insets (e.g., iOS notch / home indicator) and more reliable viewport sizing in the Page and Drawer components (and related mobile navigation positioning).
Changes:
- Add
100dvhsupport (via@supports) and safe-area padding todb-pagefixed variant. - Adjust drawer sizing/spacing to incorporate
env(safe-area-inset-*)and refine max-height behavior. - Update mobile sub-navigation positioning to include safe-area insets; add a patch changeset for component packages.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/components/src/components/page/page.scss | Uses 100dvh when supported and adds safe-area padding for fixed pages. |
| packages/components/src/components/navigation-item/navigation-item.scss | Offsets mobile sub-navigation inset-block by safe-area top/bottom. |
| packages/components/src/components/drawer/drawer.scss | Incorporates safe-area insets into drawer height/max-height and spacing. |
| .changeset/three-camels-agree.md | Adds a patch changeset describing the mobile safe-area fix. |
mfranzke
reviewed
Apr 12, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
mfranzke
moved this from 🎁 Ready for review
to 🎶 Waiting for feedback
in UX Engineering Team Backlog
Co-authored-by: Maximilian Franzke <787658+mfranzke@users.noreply.github.com>
…mobile-safe-areas
nmerget
moved this from 🎶 Waiting for feedback
to 🎁 Ready for review
in UX Engineering Team Backlog
mfranzke
reviewed
Apr 29, 2026
mfranzke
moved this from 🎁 Ready for review
to 🎶 Waiting for feedback
in UX Engineering Team Backlog
# Conflicts: # packages/components/src/components/navigation-item/navigation-item.scss
nmerget
moved this from 🎶 Waiting for feedback
to 🎁 Ready for review
in UX Engineering Team Backlog
# Conflicts: # package-lock.json
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
closes #6881
Types of changes
Further comments
🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/fix-mobile-safe-areas