test: added test case for subnavigation#6595
Open
mfranzke wants to merge 4 commits into
Open
Conversation
we're visually testing the sub–navigation inside a drawer, so we should add a test-case for that
github-project-automation
Bot
moved this to 🏗 In progress
in UX Engineering Team Backlog
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Playwright Component Test case to visually cover an expanded (nested) sub-navigation state for DBNavigationItem when rendered inside a DBDrawer, addressing the regression gap noted in #6594.
Changes:
- Imported
DBDrawerandDBNavigationinto theDBNavigationItemCT spec. - Added a nested sub-navigation fixture mounted inside an open drawer.
- Added a screenshot test that clicks to expand 2 levels of sub-navigation and snapshots the drawer.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…-sub-navigation-item
| await expect(subNavigationItemButton).toHaveAttribute('aria-expanded', 'true'); | ||
|
|
||
| const drawer = page.locator('.db-drawer'); | ||
| await expect(drawer).toHaveAttribute('data-transition', 'open'); |
…-sub-navigation-item
Comment on lines
+89
to
+91
| const drawer = page.locator('.db-drawer'); | ||
| await expect(drawer).toHaveAttribute('data-transition', 'open'); | ||
| await expect(drawer).toHaveScreenshot(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
we're visually testing the sub–navigation inside a drawer, so we should add a test-case for that
resolves #6594
Types of changes
Further comments
🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/6594-testnavigation-item-add-test-for-opened-sub-navigation-item