Skip to content

refactor: Update .gitignore to remove kiro specs directory#6873

Open
mfranzke wants to merge 1 commit into
mainfrom
refactor-removing-kiro-specs-directory-from-gitignore
Open

refactor: Update .gitignore to remove kiro specs directory#6873
mfranzke wants to merge 1 commit into
mainfrom
refactor-removing-kiro-specs-directory-from-gitignore

Conversation

@mfranzke
Copy link
Copy Markdown
Collaborator

@mfranzke mfranzke commented Jun 2, 2026

Proposed changes

Remove /.kiro/specs/ from .gitignore.

Oftentimes our PRs lack a lot of information, up to not including any description at all. Besides fixing this, any information on the initial thoughts, concepts, requirements, design and todo/tasks are helpful to understand the development in the future and that for are a crucial and essential part of the documentation.

Checklist

Code Quality

  • I have reviewed my own code (self-review)
  • I have reviewed my changes locally with an AI assistant (e.g. GitHub Copilot, Kiro, etc.)
  • No hardcoded values, magic numbers, or debug code left in

Validation

  • I have added/updated tests that cover my changes
  • I have tested across all relevant frameworks (React, Angular, Vue) if applicable

General

  • The PR title follows the conventional commits format (e.g. feat:, fix:, chore:)
  • If architecture, structure, or conventions changed inside a packages/* folder, the corresponding AGENTS.md has been updated

🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/refactor-removing-kiro-specs-directory-from-gitignore

Remove `/.kiro/specs/` from `.gitignore`. Oftentimes our PRs lack a lot of information, up to not including any description at all. Besides fixing this, any information on the initial thoughts, concepts, requirements, design and todo/tasks are helpful to understand the development in the future and that for are a crucial and essential part of the documentation.
@mfranzke mfranzke requested a review from Copilot June 2, 2026 20:03
@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Jun 2, 2026
@github-project-automation github-project-automation Bot moved this to 🏗 In progress in UX Engineering Team Backlog Jun 2, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 2, 2026

⚠️ No Changeset found

Latest commit: 91b91a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mfranzke mfranzke moved this from 🏗 In progress to 🎁 Ready for review in UX Engineering Team Backlog Jun 2, 2026
@mfranzke mfranzke enabled auto-merge (squash) June 2, 2026 20:04
@mfranzke mfranzke changed the title refactor: Update .gitignore to remove kiro specs directory refactor: Update .gitignore to remove kiro specs directory Jun 2, 2026
@nmerget
Copy link
Copy Markdown
Collaborator

nmerget commented Jun 3, 2026

Before you commit some kiro related stuff please use Kiro somehow.

I think the spec files shouldn't be commited. Look at this example:
image

There are so many specs at the moment in my project, even now I'll don't have any overview about the specs. Also most of the older specs are outdated.

In the old world without AI, commiting a spec folder is the equvivalent of pushing a User Story to you codebase. We have other tools for this. If there is any desicion you want to save, we should make a steering that we save it in docs or adr etc. But this would be just a summary and it would be an overall architecture/documentation, not a single task

@nmerget nmerget moved this from 🎁 Ready for review to 🎶 Waiting for feedback in UX Engineering Team Backlog Jun 3, 2026
@mfranzke
Copy link
Copy Markdown
Collaborator Author

mfranzke commented Jun 3, 2026

Before you commit some kiro related stuff please use Kiro somehow.

I think the spec files shouldn't be commited. Look at this example: image

There are so many specs at the moment in my project, even now I'll don't have any overview about the specs. Also most of the older specs are outdated.

In the old world without AI, commiting a spec folder is the equvivalent of pushing a User Story to you codebase. We have other tools for this. If there is any desicion you want to save, we should make a steering that we save it in docs or adr etc. But this would be just a summary and it would be an overall architecture/documentation, not a single task

I have not just used Kiro, but even also been in a workshop for using Kiro hold by Amazon. If we could somehow save the information out of these files differently, that's fine, but if all of those are lost and our PRs remain mostly undocumented, we do have a problem with missing documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🍄🆙improvement New feature or request 📅weekly

Projects

Status: 🎶 Waiting for feedback

Development

Successfully merging this pull request may close these issues.

3 participants