fix: make custom input icons render cross-browser#6876
Draft
michaelmkraus wants to merge 2 commits into
Draft
Conversation
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes cross-browser rendering of custom icons (calendar, clock) for
DBInputcomponents withdate,datetime-local, andtimeinput types. Previously, these icons were only visible in Chromium-based browsers due to a@supports selector(::-webkit-calendar-picker-indicator)restriction.date,datetime-local, andtimeicon definitions out of the@supportsblock so custom icons render in all browsers (Chromium, Firefox, Safari).monthandweekinside the@supportsblock, since Firefox doesn't support these input types and renders them as plain text fields — showing a calendar icon would be misleading.pointer-events: noneon the::afterpseudo-element to ensure custom icons don't intercept clicks meant for native picker triggers.z-index: 1on::-webkit-calendar-picker-indicatorand::-webkit-search-cancel-buttonso the invisible native click target reliably sits above the custom icon layer.resolves #5077
Checklist
Code Quality
Validation
General
feat:,fix:,chore:), as in Git Commit Conventionspackages/*folder, the correspondingAGENTS.mdhas been updated🔭🐙🐈 Test this branch here: https://design-system.deutschebahn.com/core-web/review/fix-input-icons-cross-browser