feat: Add initiator module for managing unzoned initiators on Unity storage#63
Open
mcolella88 wants to merge 3 commits into
Open
feat: Add initiator module for managing unzoned initiators on Unity storage#63mcolella88 wants to merge 3 commits into
mcolella88 wants to merge 3 commits into
Conversation
…s already existing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add initiator module with unzoned initiator support and comprehensive testing
Introduces a new initiator module for managing Dell Unity storage initiators with support for unzoned initiators and automatic host creation. Includes comprehensive unit tests (31 test cases), mock API
objects, sample playbooks, and updated documentation. This module enables flexible initiator management without requiring pre-existing zoning, addressing a key limitation in the existing host module
workflow.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Unit Tests: Created and executed 31 comprehensive unit tests covering all major module functionality including host creation/deletion, initiator validation, adding/removing initiators from hosts, and
module operations. All tests pass successfully.
Ansible Sanity Tests: Ran ansible-test sanity --test validate-modules on the initiator module to ensure compliance with Ansible module documentation and structure requirements. Tests passed with no
errors.
Code Quality: Ran ansible-lint on the initiator module to verify code quality and adherence to Ansible best practices. No linting issues found.
Documentation Validation: Verified module documentation (DOCUMENTATION, EXAMPLES, RETURN sections) for proper formatting and completeness. Fixed documentation format error to comply with Ansible
sanity requirements.
Mock API Testing: Created comprehensive mock API objects (mock_initiator_api.py) to simulate Unity storage system responses for all initiator operations, ensuring reliable unit testing without
requiring live system access.
Test Configuration: