DLPX-97954 Add support for local maven build for password-vault-manager#402
Draft
justsanjeev wants to merge 1 commit into
Draft
DLPX-97954 Add support for local maven build for password-vault-manager#402justsanjeev wants to merge 1 commit into
justsanjeev wants to merge 1 commit into
Conversation
justsanjeev
force-pushed
the
dlpx/pr/justsanjeev/0846dfd4-29bc-47f4-9cfc-d98951f0dbd3
branch
3 times, most recently
from
July 15, 2026 13:54
0289159 to
a93adf5
Compare
justsanjeev
force-pushed
the
dlpx/pr/justsanjeev/0846dfd4-29bc-47f4-9cfc-d98951f0dbd3
branch
from
July 16, 2026 07:20
a93adf5 to
bbcf88e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Testing an in-progress
password-vault-manager(PVM) change against the appliance buildcurrently requires that change to already be published to Artifactory, since
packages/virtualization/config.shalways resolves PVM at the version pinned indlpx-app-gate'sappliance/gradle.properties. Anyone validating a cross-repo changebetween
dlpx-app-gateandpassword-vault-managerhas to wait for a PVM publish (ormanually hack the pinned version) before they can even build the appliance against it,
which adds unnecessary iteration latency to development and pre-checkin testing.
Solution
Add an opt-in hook to
packages/virtualization/config.sh, gated behind two newenvironment variables,
PVM_GIT_URLandPVM_GIT_BRANCH:build()shallow-clones that ref ofpassword-vault-manager, runs./gradlew publishToMavenLocal(skippingtest/dxosTest, since those already ran aspart of the
password-vault-manager-precommit-testsstep earlier in thepvm_precheckinflow) to publish the jar into~/.m2/repository, and passes-Dthird.party.local.maven.root=file://$HOME/.m2/repositoryandORG_GRADLE_PROJECT_passwordVaultManagerVer=<local version>to theantbuild, so ivyresolves the locally-built jar instead of the Artifactory one.
fetched from Artifactory using the version pinned in
appliance/gradle.properties--no behavior change for existing builds.
This lets a developer point a virtualization build at an unpublished PVM branch for
local validation without touching the pinned version or waiting on a publish.
Testing Done
integration-tests/password-vault-manager-precommit-tests/pre-push(unit + dxos tests)propagate: false834231db1)