Conversation
Thembahank
added a commit
to Erteno/django-unicorn
that referenced
this pull request
Apr 8, 2021
Initial work for supporting ASGI. https://github.com/adamghill/django: Merged ASGI Branch until PR django-commons#121 is resolved
Contributor
|
I am curious what under changes we need to make to fully support async |
Member
Author
Off the top of my head:
Although, would need to dig into this more. Personally, I'd like to understand if the code complexity is worth the effort. |
Contributor
|
Well i think the code will be a bit complex |
Contributor
well cant we use sync_to_async for all the currently sync sections of django? well i think some models methods in the orm have async support? I mean just thinking aloud |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.