Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tippexs
left a comment
tippexs
left a comment
There was a problem hiding this comment.
Just a small remark. Other then that, Great Work LGTM
| ```yaml | ||
| services: | ||
| postgres: | ||
| image: postgres:17.7 |
There was a problem hiding this comment.
Is there a reason why we do use 17.7 instead of 18 as in the rest of the guide?
craig-osterhout
left a comment
craig-osterhout
left a comment
There was a problem hiding this comment.
Thanks @igor-alexandrov and all.
It looks great!
I left mostly style nits, not any technical blockers.
content/guides/postgresql/advanced-configuration-and-initialization.md
Outdated
Show resolved
Hide resolved
content/guides/postgresql/advanced-configuration-and-initialization.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Craig Osterhout <craig.osterhout@docker.com>
Co-authored-by: Craig Osterhout <craig.osterhout@docker.com>
Co-authored-by: Craig Osterhout <craig.osterhout@docker.com>
Co-authored-by: Craig Osterhout <craig.osterhout@docker.com>
Co-authored-by: Craig Osterhout <craig.osterhout@docker.com>
Co-authored-by: Craig Osterhout <craig.osterhout@docker.com>
Co-authored-by: Craig Osterhout <craig.osterhout@docker.com>
Co-authored-by: Craig Osterhout <craig.osterhout@docker.com>
Co-authored-by: Craig Osterhout <craig.osterhout@docker.com>
Co-authored-by: Craig Osterhout <craig.osterhout@docker.com>
Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…ation.md Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
…ation.md Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
|
@craig-osterhout @dvdksn we resolved all your comments. Thank you for finding a time to review this. |
|
/review |
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This comprehensive PostgreSQL containerization guide is well-structured and provides clear, practical examples for users. The content accurately explains Docker concepts, PostgreSQL configuration, and networking patterns.
The guide successfully covers:
- Data persistence with named volumes and bind mounts
- Initialization scripts and performance tuning
- Container networking for both internal and external access
- Ecosystem tools like pgAdmin and PgBouncer
All commands are correct, examples are functional, and the progressive structure (from quick start to advanced topics) makes this approachable for users at different skill levels.
No blocking issues found. Great work! 🎉
5 participants
Description
This PR introduces a new PostgreSQL-specific guide to help users containerize PostgreSQL databases using Docker. The guide is structured into four progressive modules:
Immediate Setup & Data Persistence - Covers running PostgreSQL containers with proper data persistence using named volumes, bind mounts, and Docker Compose configurations.
Advanced Configuration and Initialization - Explains initialization scripts (/docker-entrypoint-initdb.d/), performance tuning parameters (memory settings, connection limits, I/O
configuration), and timezone/locale settings.
Networking and Connectivity - Details how to configure networking for containerized PostgreSQL deployments.
Companions for PostgreSQL - Introduces ecosystem tools including pgAdmin 4 for visual management, PgBouncer and Pgpool-II for connection pooling, and pgbench for performance testing.
Examples include tabs showing both Docker Hardened Images (DHI) and Docker Official Images (DOI) variants where applicable.
The guide is prepared by @igor-alexandrov, @edithturn, and @Expeto.
Reviews