Fix mypy 2.x type errors in client and cloudpath modules#566
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #566 +/- ##
======================================
Coverage 94.0% 94.0%
======================================
Files 28 28
Lines 2222 2222
======================================
Hits 2090 2090
Misses 132 132
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest mypy 2.x reports type errors that cause
make lintto fail when dev dependencies are upgraded. This PR adds aClassVarannotation forClient._default_clientand narrows the return type ofget_default_client()so lazy initialization type-checks correctly. InCloudPath._dispatch_to_path, path parent sequences now filter withisinstance(p, PurePosixPath)before calling_resolve. Linting passes locally with black, flake8, and mypy.Closes #563