[Android Maintenance] Allow reasoning mode values in unified input prompt_submitted reasoning_effort pixel#9019
Closed
daxmobile wants to merge 1 commit into
Conversation
…ng_effort pixel The m_aichat_unified_input_prompt_submitted_count and _daily pixels failed live validation: reasoning_effort carries values outside the declared enum. The only other reasoning vocabulary in the feature is the ReasoningMode rawValues (fast/reasoning/extended_reasoning), which the sibling reasoning_effort_selected pixel and the firePromptSubmitted unit test already use. Widen the enum to the union of effort and mode values so field data from all app versions validates. Definition-only change; no behaviour change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1202552961248957/task/1215891186389639
Tech Design URL (if applicable):
Description
The pixels
m_aichat_unified_input_prompt_submitted_countandm_aichat_unified_input_prompt_submitted_dailyfailed live validation with:Root cause: the
reasoning_effortparameter on these pixels was declared with theenum["none", "minimal", "low", "medium", "high"](theReasoningEffortrawValues). However, the Duck.ai reasoning feature has a second, user-facing vocabulary — theReasoningModerawValuesfast/reasoning/extended_reasoning(seeReasoning.kt). That same mode vocabulary is what the sibling pixelm_aichat_unified_input_reasoning_effort_selectedalready documents for itseffort_levelparameter, and what thefirePromptSubmittedunit test passes forreasoningEffort("fast"). The only reasoning vocabularies in the feature are these two, so the live values failing the effort-only enum are the reasoning mode values.Fix: widen the
reasoning_effortenum on both pixels to the union of the effort and mode values (["none", "minimal", "low", "medium", "high", "fast", "reasoning", "extended_reasoning"]) and update the description accordingly, so field data from all app versions validates.This is a pixel-definition (JSON5) change only — no Kotlin/app code is touched, so there is no behaviour change. Adding values to a validation enum is non-breaking: it only widens what validation accepts and cannot affect any currently-valid pixels.
🤖 Android Maintenance Worker
Steps to test this PR
Pixel definition validation
cd PixelDefinitions && npm cinpm run validate-defs-without-formatting— schema validationnpm run lint— Prettier formatting checkNote:
npm run lint(Prettier) passes locally.validate-defs-without-formattingcould not complete in the sandbox because it fetches the product target version over the network (ERROR in product.json target version: fetch failed) — an infrastructure/firewall limitation unrelated to this change, which occurs before any definition is validated. CI runs this check with network access. No Gradle/spotless/unit-test changes apply because no Kotlin sources were modified.UI changes
Note
🔒 Integrity filter blocked 17 items
The following items were blocked because they don't meet the GitHub integrity level.
list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".list_pull_requests: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".To allow these resources, lower
min-integrityin your GitHub frontmatter: