Add reinstaller quick setup Maestro tests coverage and remove previous skip-onboarding tests#9200
Merged
catalinradoiu merged 2 commits intoJul 16, 2026
Conversation
…verage The returning-user "I've been here before" flow now leads to the quick setup screen instead of the old tutorial/start-browsing dialogs, so the previous release-blocking tests no longer match the app's behavior. Replace them with non-release-blocking coverage for the quick setup flow (customize + start browsing) gated behind the onboardingQuickSetup experiment treatment config patch. Task/Issue URL: https://app.asana.com/1/137249556945/project/1211724162604201/task/1214735718762065?focus=true
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
catalinradoiu
marked this pull request as ready for review
July 16, 2026 08:56
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit be9a566. Configure here.
CDRussell
approved these changes
Jul 16, 2026
catalinradoiu
deleted the
feature/cradoiu/update-skip-onboarding-maestro-tests
branch
July 16, 2026 14:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Task/Issue URL: https://app.asana.com/1/137249556945/project/1211724162604201/task/1214735718762065?focus=true
Tech Design URL (if applicable):
Description
The returning-user "I've been here before" flow now leads to the quick setup screen (address bar position, search options, default browser, widget) instead of the old tutorial/start-browsing dialogs. The two release-blocking Maestro tests asserting the old dialog copy no longer match the app's behavior, so this replaces them with coverage of the new quick setup flow:
preonboarding_returning_user_quick_setup_customize.yaml— selects bottom address bar position and "search only", sets DuckDuckGo as default, then taps Start Browsing and asserts the address bar renders at the bottom of the screen.preonboarding_returning_user_quick_setup_start_browsing.yaml— taps Start Browsing without customizing anything.Both are gated behind a new remote config patch (
remote_config_patches/enable_onboarding_quick_setup_experiment_treatment.json) that forces theonboardingQuickSetupExperimentJun3cohort to treatment. The patch will be removed once #9181 is merged.Steps to test this PR
Maestro cloud run: https://app.maestro.dev/project/proj_01htg54rdtfwx8rgbzv03cxkpf/maestro-test/app/app_01hkqhj1thevwtn9ym8a2ctn2r/upload/mupload_01kxngkd87e9694n996dcc2162
Maestro coverage
./gradlew installInternalRelease -Pconfig_patches=.maestro/onboarding/remote_config_patches/enable_onboarding_quick_setup_experiment_treatment.jsonmaestro test .maestro/onboarding/preonboarding_returning_user_quick_setup_customize.yamland confirm it passes, including the new bottom-address-bar assertion after Start Browsingmaestro test .maestro/onboarding/preonboarding_returning_user_quick_setup_start_browsing.yamland confirm it passesUI changes
Note
Low Risk
Changes are limited to Maestro flows and nightly CI config; no production app logic.
Overview
Updates Maestro coverage for the returning-user “I’ve been here before” path now that it lands on quick setup instead of the old skip/tutorial dialogs.
Removes
preonboarding_returning_user_show_tutorial.yamlandpreonboarding_returning_user_start_browsing.yaml(they asserted obsolete copy). Addspreonboarding_returning_user_quick_setup_start_browsing.yamlandpreonboarding_returning_user_quick_setup_customize.yaml, taggedonboardingNonReleaseBlockingTest, covering Start Browsing as-is and a customize path (address bar position, search-only, default browser) with a bottom-toolbar assertion after launch.CI: Nightly non-blockers workflow applies
enable_onboarding_quick_setup_experiment_treatment.jsonvia-Pconfig_patches(forcesonboardingQuickSetupExperimentJun3to treatment) and runs a new Onboarding Maestro job with that tag.Reviewed by Cursor Bugbot for commit f70eb79. Bugbot is set up for automated code reviews on this repo. Configure here.