Skip to content

Add reinstaller quick setup Maestro tests coverage and remove previous skip-onboarding tests#9200

Merged
catalinradoiu merged 2 commits into
developfrom
feature/cradoiu/update-skip-onboarding-maestro-tests
Jul 16, 2026
Merged

Add reinstaller quick setup Maestro tests coverage and remove previous skip-onboarding tests#9200
catalinradoiu merged 2 commits into
developfrom
feature/cradoiu/update-skip-onboarding-maestro-tests

Conversation

@catalinradoiu

@catalinradoiu catalinradoiu commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Task/Issue URL: https://app.asana.com/1/137249556945/project/1211724162604201/task/1214735718762065?focus=true
Tech Design URL (if applicable):

Description

The returning-user "I've been here before" flow now leads to the quick setup screen (address bar position, search options, default browser, widget) instead of the old tutorial/start-browsing dialogs. The two release-blocking Maestro tests asserting the old dialog copy no longer match the app's behavior, so this replaces them with coverage of the new quick setup flow:

  • preonboarding_returning_user_quick_setup_customize.yaml — selects bottom address bar position and "search only", sets DuckDuckGo as default, then taps Start Browsing and asserts the address bar renders at the bottom of the screen.
  • preonboarding_returning_user_quick_setup_start_browsing.yaml — taps Start Browsing without customizing anything.

Both are gated behind a new remote config patch (remote_config_patches/enable_onboarding_quick_setup_experiment_treatment.json) that forces the onboardingQuickSetupExperimentJun3 cohort to treatment. The patch will be removed once #9181 is merged.

Steps to test this PR

Maestro cloud run: https://app.maestro.dev/project/proj_01htg54rdtfwx8rgbzv03cxkpf/maestro-test/app/app_01hkqhj1thevwtn9ym8a2ctn2r/upload/mupload_01kxngkd87e9694n996dcc2162

Maestro coverage

  • Build an internal APK with the config patch applied: ./gradlew installInternalRelease -Pconfig_patches=.maestro/onboarding/remote_config_patches/enable_onboarding_quick_setup_experiment_treatment.json
  • Run maestro test .maestro/onboarding/preonboarding_returning_user_quick_setup_customize.yaml and confirm it passes, including the new bottom-address-bar assertion after Start Browsing
  • Run maestro test .maestro/onboarding/preonboarding_returning_user_quick_setup_start_browsing.yaml and confirm it passes

UI changes

Before After
No UI changes No UI changes

Note

Low Risk
Changes are limited to Maestro flows and nightly CI config; no production app logic.

Overview
Updates Maestro coverage for the returning-user “I’ve been here before” path now that it lands on quick setup instead of the old skip/tutorial dialogs.

Removes preonboarding_returning_user_show_tutorial.yaml and preonboarding_returning_user_start_browsing.yaml (they asserted obsolete copy). Adds preonboarding_returning_user_quick_setup_start_browsing.yaml and preonboarding_returning_user_quick_setup_customize.yaml, tagged onboardingNonReleaseBlockingTest, covering Start Browsing as-is and a customize path (address bar position, search-only, default browser) with a bottom-toolbar assertion after launch.

CI: Nightly non-blockers workflow applies enable_onboarding_quick_setup_experiment_treatment.json via -Pconfig_patches (forces onboardingQuickSetupExperimentJun3 to treatment) and runs a new Onboarding Maestro job with that tag.

Reviewed by Cursor Bugbot for commit f70eb79. Bugbot is set up for automated code reviews on this repo. Configure here.

…verage

The returning-user "I've been here before" flow now leads to the quick
setup screen instead of the old tutorial/start-browsing dialogs, so the
previous release-blocking tests no longer match the app's behavior.
Replace them with non-release-blocking coverage for the quick setup
flow (customize + start browsing) gated behind the onboardingQuickSetup
experiment treatment config patch.

Task/Issue URL: https://app.asana.com/1/137249556945/project/1211724162604201/task/1214735718762065?focus=true

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@catalinradoiu catalinradoiu changed the title Replace skip-onboarding Maestro tests with reinstaller quick setup coverage Add reinstaller quick setup Maestro tests coverage and remove previous skip-onboarding tests Jul 16, 2026
@catalinradoiu
catalinradoiu marked this pull request as ready for review July 16, 2026 08:56

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit be9a566. Configure here.

Comment thread .maestro/onboarding/preonboarding_returning_user_quick_setup_customize.yaml Outdated
@CDRussell CDRussell self-assigned this Jul 16, 2026
@catalinradoiu
catalinradoiu merged commit e102815 into develop Jul 16, 2026
26 checks passed
@catalinradoiu
catalinradoiu deleted the feature/cradoiu/update-skip-onboarding-maestro-tests branch July 16, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants