Add simplified device backup flow#9210
Open
MiSikora wants to merge 2 commits into
Open
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e3ebb11. Configure here.
MiSikora
commented
Jul 16, 2026
12 tasks
CDRussell
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Task/Issue URL: https://app.asana.com/1/137249556945/project/1216103556496795/task/1216422585541210?focus=true
Tech Design URL (if applicable): https://app.asana.com/1/137249556945/project/1216103556496795/task/1216509582049467?focus=true
Description
Adds the "back up this device" flow to the simplified sync UI. When a signed-out user turns on the Sync this device toggle on the new sync settings screen, they now go through a dedicated intro screen and can create a sync account to back this device up.
Added:
SyncThisDeviceActivity) with two CTAs — "Sync With Another Device" and "Sync This Device Only".SyncActivityviaSyncThisDeviceContract(ActivityResultContract), including device authentication, device-unsupported and passcode-enrollment guards.Not implemented here (follow-up PRs):
RecoveryCodeActivity). A successful backup routes to it, but showing/saving the recovery code (and the PDF) will come in its own PR — I'd rather isolate it.Steps to test this PR
Back up this device (simplified sync)
UI changes
Note
Medium Risk
Touches sync account creation, device authentication, and signup analytics on a new user-facing path; recovery and several v2 settings commands are still unimplemented.
Overview
Adds the simplified “back up this device” path on sync settings v2: turning on Sync & Backup this device runs device-auth / passcode enrollment checks, then opens a dedicated intro via
SyncThisDeviceContract.Sync This Device intro (
SyncThisDeviceActivity) offers Sync With Another Device (returns to settings; pairing not wired yet) and Sync This Device Only, which creates a sync account throughSyncAccountRepository, shows a syncing state, and emits sync-setup wide events and signup pixels. Cancel or dismiss resets the settings toggle via newSyncThisDeviceCanceledhandling in v2SyncActivity(legacy sync activity ignores that command).Successful backup refreshes the device list and navigates to a placeholder
RecoveryCodeActivity. Most other v2SyncActivitycommands remain TODO stubs. Manifest registers the new activities; strings and layout support the intro screen.Reviewed by Cursor Bugbot for commit e3ebb11. Bugbot is set up for automated code reviews on this repo. Configure here.