Skip to content

Add translation to hatch strings#9218

Open
YoussefKeyrouz wants to merge 52 commits into
developfrom
feature/youssef/new-tab-return-hatch-smartling
Open

Add translation to hatch strings#9218
YoussefKeyrouz wants to merge 52 commits into
developfrom
feature/youssef/new-tab-return-hatch-smartling

Conversation

@YoussefKeyrouz

@YoussefKeyrouz YoussefKeyrouz commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Task/Issue URL: https://app.asana.com/1/137249556945/project/1212810093780571/task/1215861246875406?focus=true
Tech Design URL (if applicable):

Description

Translation PR for all strings related to the Hatch and idle settings.


Note

Low Risk
Resource-only localization and string file moves; no application logic or security-sensitive behavior changes.

Overview
Adds localized copy for the New Tab “return hatch” UI and the Return To Last Tab setting that lives with After Inactivity settings, and reorganizes where those strings live in resources.

Hatch-related labels (return shortcut, Fire tab title, undo/closed states, hatch menu actions) move out of donottranslate.xml into new strings-new-tab-return-hatch.xml in browser-ui, with matching values-* locale files. The idle-setting toggle strings returnToLastTabSettingTitle / returnToLastTabSettingSubtitle move from app donottranslate.xml into strings-settings.xml (default plus the same set of locales).

Also includes small Danish ad-blocking string tweaks (Annuller spelling, omnibar badge wording).

Reviewed by Cursor Bugbot for commit abb974f. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Translate strings-ad-blocking to values-nb
Translate strings-ad-blocking to values-lt
Translate strings-ad-blocking to values-hr
Translate strings-ad-blocking to values-bg
Translate strings-ad-blocking to values-sv
Translate strings-ad-blocking to values-pl
Translate strings-ad-blocking to values-ru
Translate strings-ad-blocking to values-nl
Translate strings-ad-blocking to values-lv
Translate strings-ad-blocking to values-pt
Translate strings-ad-blocking to values-sk
Translate strings-ad-blocking to values-et
Translate strings-ad-blocking to values-fr
<string name="ad_blocking_disabled_primary_action">Send feilrapport</string>
<string name="ad_blocking_disabled_secondary_action">Avbryt</string>
<string name="ad_blocking_settings_disabled_until_relaunch">Deaktivert til relansering</string>
<string name="ad_blocking_settings_disabled_until_relaunch">Deaktiver til neste oppstart</string>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Settings status uses imperative Norwegian

Low Severity

ad_blocking_settings_disabled_until_relaunch is shown as secondary status text on the ad blocking settings row, but the Norwegian string reads as an imperative (“Deaktiver til neste oppstart”) and matches the menu action string. It should describe the current disabled state (past participle), like Danish Deaktiveret … and the previous Deaktivert til relansering.

Fix in Cursor Fix in Web

Triggered by learned rule: Do not flag string resource copy content (grammar, wording, phrasing)

Reviewed by Cursor Bugbot for commit ac433a2. Configure here.

smartling added 26 commits July 16, 2026 17:51
Translate strings to values-es
Translate strings to values-ro
Translate strings to values-tr
Translate strings to values-sk
Translate strings to values-ru
Translate strings to values-et
Translate strings to values-it
Translate strings to values-pl
Translate strings to values-bg
Translate strings to values-lv
Translate strings to values-fi
Translate strings to values-sl
Translate strings to values-nl
Translate strings to values-hr
Translate strings to values-hu
Translate strings to values-nb
Translate strings to values-sv
Translate strings to values-da
Translate strings to values-el
Translate strings to values-fr
Translate strings to values-lt
Translate strings to values-pt
Translate strings to values-cs
Translate strings-downloads to values-fi
Translate strings-downloads to values-sv
Translate strings-downloads to values-nb
Translate strings-downloads to values-et
Translate strings-downloads to values-hr
Translate strings-downloads to values-sk
Translate strings-downloads to values-pt
Translate strings-downloads to values-es
Translate strings-downloads to values-el
Translate strings-downloads to values-fr
Translate strings-downloads to values-ru
Translate strings-downloads to values-tr
Translate strings-downloads to values-it
Translate strings-downloads to values-pl
Translate strings-downloads to values-bg
Translate strings-downloads to values-da
Translate strings-downloads to values-hu
Translate strings-downloads to values-nl
Translate strings-downloads to values-cs
Translate strings-downloads to values-de
Translate strings-downloads to values-lt
Translate strings-downloads to values-sl
Translate strings-downloads to values-ro
Translate strings-feedback to values-pl
Translate strings-feedback to values-pt
Translate strings-feedback to values-ro
Translate strings-feedback to values-bg
Translate strings-feedback to values-de
Translate strings-feedback to values-da
Translate strings-feedback to values-el
Translate strings-feedback to values-et
Translate strings-feedback to values-fi
Translate strings-feedback to values-hu
Translate strings-feedback to values-it
Translate strings-feedback to values-tr
Translate strings-feedback to values-cs
Translate strings-feedback to values-nl
Translate strings-feedback to values-ru
Translate strings-feedback to values-sl
Translate strings-feedback to values-sv
Translate strings-feedback to values-lv
Translate strings-feedback to values-lt
Translate strings-feedback to values-nb
Translate strings-feedback to values-es
Translate strings-feedback to values-fr
Translate strings-feedback to values-hr
Translate strings-settings to values-sl
Translate strings-new-tab-return-hatch to values-hu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant