Dispose bold/italic fonts in FontRegistry upon display disposal#3759
Merged
HeikoKlare merged 2 commits intoeclipse-platform:masterfrom Mar 6, 2026
Merged
Conversation
The FontRegistry implementation uses hooks to dispose registered fonts upon disposal of the display they have been created for. This implementation does, however, only cover the base fonts but not the bold/italic versions of them. In case only a bold/italic font of a record is created on a separate display, no dispose hook for that display will be created, such that those fonts will not be disposed when the display becomes disposed. In consequence, fonts for non-disposed devices may be returned by the registry. This change improves the FontRegistry implementation to create a display dispose hook also upon creation of a bold/italic font.
b5490c6 to
d807b51
Compare
Contributor
|
This pull request changes some projects for the first time in this development cycle. Warning 🚧 This PR cannot be modified by maintainers because edits are disabled or it is created from an organization repository. To obtain the required changes apply the git patch manually as an additional commit. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Contributor
BeckerWdf
reviewed
Mar 3, 2026
Member
BeckerWdf
left a comment
There was a problem hiding this comment.
just read the code - did not test.
But code looks good to me.
6fab0d0 to
d29b58d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FontRegistry implementation uses hooks to dispose registered fonts upon disposal of the display they have been created for. This implementation does, however, only cover the base fonts but not the bold/italic versions of them. In case only a bold/italic font of a record is created on a separate display, no dispose hook for that display will be created, such that those fonts will not be disposed when the display becomes disposed. In consequence, fonts for non-disposed devices may be returned by the registry.
This change improves the FontRegistry implementation to create a display dispose hook also upon creation of a bold/italic font.