Improve terminal creation handling & grouping in TerminalManager#17587
Open
colin-grant-work wants to merge 4 commits into
Open
Improve terminal creation handling & grouping in TerminalManager#17587colin-grant-work wants to merge 4 commits into
colin-grant-work wants to merge 4 commits into
Conversation
Contributor
Author
|
Marking as a draft while I look at #17157 |
2b5f431 to
05a8b1c
Compare
Contributor
Author
|
To address #17157, I ended up making some changes upstream of the terminal manager in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Closes #17411
Closes #17157
Adjusts the way the terminal manager takes ownership of terminals by implementing a contribution system to handle placement of terminals in the layout. This eliminates various mechanisms used by the terminal manager to try to distinguish between terminals it opened itself and those opened by other callers.
How to test
Follow testing from #17403
Follow-ups
Breaking changes
Attribution
Review checklist
nlsservice (for details, please see the Internationalization/Localization section in the Coding Guidelines)Reminder for reviewers