Skip to content

Improve terminal creation handling & grouping in TerminalManager#17587

Open
colin-grant-work wants to merge 4 commits into
masterfrom
feature/terminal-creation-delegation-17411
Open

Improve terminal creation handling & grouping in TerminalManager#17587
colin-grant-work wants to merge 4 commits into
masterfrom
feature/terminal-creation-delegation-17411

Conversation

@colin-grant-work
Copy link
Copy Markdown
Contributor

@colin-grant-work colin-grant-work commented May 31, 2026

What it does

Closes #17411
Closes #17157

Adjusts the way the terminal manager takes ownership of terminals by implementing a contribution system to handle placement of terminals in the layout. This eliminates various mechanisms used by the terminal manager to try to distinguish between terminals it opened itself and those opened by other callers.

How to test

Follow testing from #17403

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

@github-project-automation github-project-automation Bot moved this to Waiting on reviewers in PR Backlog May 31, 2026
@colin-grant-work colin-grant-work marked this pull request as draft May 31, 2026 22:45
@colin-grant-work
Copy link
Copy Markdown
Contributor Author

Marking as a draft while I look at #17157

@colin-grant-work colin-grant-work force-pushed the feature/terminal-creation-delegation-17411 branch from 2b5f431 to 05a8b1c Compare June 5, 2026 20:35
@colin-grant-work colin-grant-work marked this pull request as ready for review June 5, 2026 20:35
@colin-grant-work
Copy link
Copy Markdown
Contributor Author

To address #17157, I ended up making some changes upstream of the terminal manager in core's tree utilities. I think those changes are correct and the old behavior was just buggy / leaky (if mostly benign), but if we prefer not to change the core tree utilities, the problems can be worked around more locally.

@colin-grant-work colin-grant-work changed the title Feature/terminal creation delegation 17411 Improve terminal creation handling & grouping in TerminalManager Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Waiting on reviewers

Development

Successfully merging this pull request may close these issues.

terminal-manager: make terminal ownership explicit at creation terminal-manager: Task integration follow-ups

1 participant