Add *essential* stalled / ending-too-soon debugging utilities.#30
Open
NullVoxPopuli wants to merge 2 commits intomainfrom
Open
Add *essential* stalled / ending-too-soon debugging utilities.#30NullVoxPopuli wants to merge 2 commits intomainfrom
NullVoxPopuli wants to merge 2 commits intomainfrom
Conversation
mansona
requested changes
Jun 6, 2025
Member
mansona
left a comment
mansona
left a comment
There was a problem hiding this comment.
I don't disagree with you that these things are essential, but this is the kind of thing that we should have a micro RFC about with an especially strong focus on the "how we teach this" section.
Adding these things and having no official documentation anywhere to tell people how to use them is just pointless 😞
Contributor
Author
|
i agree with that -- our testing docs in the guides are actually quite weak! This PR gives me a reminder tho so I stop forgetting about this stuff. (been on/off about it for yeeeeaaaaars) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These utilities are essential for debugging anything related to:
Specifically, snapshotTimers is good because it serializer the waiter information so it doesn't change out from underneath if you if you were to just do
getPendingWaiterState()and log that out.