If no ENABLE_EEPROM_SETTINGS is used in MakeFile, a 0 byte eeprom is generated#149
Open
tned73 wants to merge 1 commit intoemsec:masterfrom
Open
If no ENABLE_EEPROM_SETTINGS is used in MakeFile, a 0 byte eeprom is generated#149tned73 wants to merge 1 commit intoemsec:masterfrom
tned73 wants to merge 1 commit intoemsec:masterfrom
Conversation
Collaborator
|
I think a better solution to this problem is to add a new command to the chameleon command line, e.g. "SETTING_STORAGE=OFF" that is set to ON automatically on every startup by default. It prevents the eeprom from being updated on setting change. This could be easily Integrated into any automated script. |
Author
|
That is a nicer solution. This patch only fixes some points with the existing Makefile parameter. The parameter implies that you can use eeprom, so if you don't, now there is no eeprom used. De Command line option and this fix are not mutely exclusive, both can be implemented at the same time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the Makefile setting
SETTINGS += -DENABLE_EEPROM_SETTINGS
The application still reads the EEPROM for default settings and the LogInit function still uses EEPROM.
Due to the worn out EEPROM of my xmega, I wanted to run the application without a single EEPROM read or write.
This branch makes the .eep file has 0 bytes to write and every thing still works.
The LogInit function is now horrible, can't figure out why there needs to be a EEPROM read and write. but I have no working EEPROM, so I can't test a rewrite.