dym: add local filename dym support to all extensions#45512
Merged
wbpcode merged 8 commits intoJun 11, 2026
Merged
Conversation
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
… dev-support-data-sources-based-extensions-to-others
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
wbpcode
requested review from
agrawroh,
mathetake and
mattklein123
as code owners
Member
Author
|
/retest |
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
… dev-support-data-sources-based-extensions-to-others
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
Signed-off-by: wbpcode/wangbaiping <wbphub@gmail.com>
mathetake
approved these changes
Jun 10, 2026
Member
Author
|
/retest |
agrawroh
reviewed
Jun 10, 2026
Comment on lines
+878
to
+880
| // Load the dynamic module. Dynamic module clusters do not support remote module sources, so no | ||
| // init manager or async callback is passed; only the synchronous local-file and by-name paths | ||
| // can succeed here. |
Member
There was a problem hiding this comment.
It'd be very nice for us to support this for Clusters and other extensions. Not sure how hard would it be.
Member
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: dym: add local filename dym support to all extensions
Additional Description:
Now all dynamic modules could use the module.local.filename to specific the module's patch and to avoid put all modules in same path and reference it with name.
Risk Level: low.
Testing: unit.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.