[v1.38] Fix bug where RTDS runtime overrides being deleted would not restore the default value#45533
Merged
Merged
Conversation
…the default value (envoyproxy#45477) Implemented failing-integration-test-first, proving the bug existed. Assisted by Codex 5.5 xhigh, but I went over all the changes manually and cleaned up several. I don't think it's possible to sanely runtime-guard the change, because how can you possibly make runtime-guards optionally not update correctly based on a runtime-guard? Updating that value would work if set and not work if not set, very confusingly. Issue was discovered when we tried to turn the recent "cookie overload" patch back on after tuning the limits, and it appeared to be fine, but then wasn't fine on instances deployed after the reset - the runtime override to "off" was still in effect on the original instances, while admin `/runtime` on the same instance was reporting no such override. Risk Level: Small - it is a behavior change, but the old behavior was incorrect, and unlikely to have been positively relied upon. Testing: Integration test and unit test. Docs Changes: n/a Release Notes: yes Platform Specific Features: n/a --------- Signed-off-by: Raven Black <ravenblack@dropbox.com>
phlax
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented failing-integration-test-first, proving the bug existed.
Assisted by Codex 5.5 xhigh, but I went over all the changes manually and cleaned up several.
I don't think it's possible to sanely runtime-guard the change, because how can you possibly make runtime-guards optionally not update correctly based on a runtime-guard? Updating that value would work if set and not work if not set, very confusingly.
Issue was discovered when we tried to turn the recent "cookie overload" patch back on after tuning the limits, and it appeared to be fine, but then wasn't fine on instances deployed after the reset - the runtime override to "off" was still in effect on the original instances, while admin
/runtimeon the same instance was reporting no such override.Risk Level: Small - it is a behavior change, but the old behavior was incorrect, and unlikely to have been positively relied upon. Testing: Integration test and unit test.
Docs Changes: n/a
Release Notes: yes
Platform Specific Features: n/a