[platform_manager] Implement AMD CPU_BUS resolution via ACPI#956
Draft
[platform_manager] Implement AMD CPU_BUS resolution via ACPI#956
Conversation
somasun
requested review from
RomanChoporov-Meta,
Scott8440,
binhuang00,
lohithchittineni,
mikechoifb and
tao-ren
as code owners
…rmware_node/path Summary: Implement resolveAmdCpuBusNums() for AMD FireRange CPUs. DesignWare I2C adapters share identical names, so bus identification uses ACPI firmware_node/path under /sys/devices/platform/AMDI0010:*. Maps \_SB_.I2CA to CPU_BUS@0 and \_SB_.I2CB to CPU_BUS@1. Also updates ConfigValidator to allow CPU_BUS@1 (needed for AMD two-bus configs) and adds duplicate name detection. Test Plan: config_validator_test i2c_explorer_test tested on a unit
somasun
force-pushed
the
amd-bus-branch
branch
from
47a9132 to
e6b89b2
Compare
|
@binhuang00 has imported this pull request. If you are a Meta employee, you can view this in D94190568. |
Contributor
|
Vendor name on the title please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Implement resolveAmdCpuBusNums() for AMD FireRange CPUs.
DesignWare I2C adapters share identical names, so bus
identification uses ACPI firmware_node/path under
/sys/devices/platform/AMDI0010:*. Maps _SB_.I2CA to
CPU_BUS@0 and _SB_.I2CB to CPU_BUS@1.
Also updates ConfigValidator to allow CPU_BUS@1 (needed
for AMD two-bus configs) and adds duplicate name detection.
Test Plan:
config_validator_test
i2c_explorer_test
tested on a unit