Skip to content

Added microtime for more unique ness#180

Open
knvpk wants to merge 1 commit into
flowjs:masterfrom
knvpk:master
Open

Added microtime for more unique ness#180
knvpk wants to merge 1 commit into
flowjs:masterfrom
knvpk:master

Conversation

@knvpk

@knvpk knvpk commented Jun 9, 2016

Copy link
Copy Markdown

related to issue #179

@AidasK

AidasK commented Jun 9, 2016

Copy link
Copy Markdown
Member

How is it possible, for a file, to have micro_time attribute?

I think you can make use of this:
https://developer.mozilla.org/en-US/docs/Web/API/File/lastModifiedDate

@knvpk

knvpk commented Jun 9, 2016

Copy link
Copy Markdown
Author

What you have linked is deprecated and there is also chances of same name,same size and same lastModifiedTime,So im attaching a new one. File doesn't have any micro_time key, but im attaching one if there is no one.

@drzraf

drzraf commented Jan 11, 2021

Copy link
Copy Markdown
Collaborator

relativePath += "-" + (lastModified || Date.now());
Sounds reasonable isn't?

@drzraf

drzraf commented Sep 15, 2021

Copy link
Copy Markdown
Collaborator

@AidasK : What do you think?

@AidasK

AidasK commented Sep 16, 2021

Copy link
Copy Markdown
Member

Why do we need that generateUniqueIdentifier would modify our file instance?

Also more uniqueness means file might not get resumed, if this is the intention, I think it can be solved differently.

Also, there is a new property which is not deprecated https://developer.mozilla.org/en-US/docs/Web/API/File/lastModified

@drzraf

drzraf commented Sep 16, 2021

Copy link
Copy Markdown
Collaborator

Using lastModified is what I suggested to add more uniqueness.
(Note that if lastModified changed, we may actually prefer not to resume such a file)
Does it mean you're rather favorable to a PR going into that direction? (I could soon provide one)

@AidasK

AidasK commented Sep 17, 2021

Copy link
Copy Markdown
Member

Yes, let’s use lastModified for more uniqueness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants