feat(fluent-operator): Add support for adding Fluent Bit ServiceMonitor labels (#605)#607
Open
erhhung wants to merge 3 commits intofluent:mainfrom
Open
feat(fluent-operator): Add support for adding Fluent Bit ServiceMonitor labels (#605)#607erhhung wants to merge 3 commits intofluent:mainfrom
erhhung wants to merge 3 commits intofluent:mainfrom
Conversation
Signed-off-by: Erhhung Yuan <erhhung@gmail.com>
erhhung
requested review from
benjaminhuo,
wanjunlei and
wenchajun
as code owners
erhhung
changed the title
wanjunlei
approved these changes
May 12, 2025
wenchajun
approved these changes
May 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
.Values.fluentbit.serviceMonitor.labelsto thefluent-operatorchart's service monitor template and comments in the corresponding values file (also borrowed some from thefluent-bitchart values file).Did not change existing default behavior.
Fixed some YAML indentation inconsistencies in the values file.